pydoctyle plugin: The 'match' option in a config file isn't ignored#524
Open
vpunch wants to merge 2 commits intopython-lsp:developfrom
Open
pydoctyle plugin: The 'match' option in a config file isn't ignored#524vpunch wants to merge 2 commits intopython-lsp:developfrom
vpunch wants to merge 2 commits intopython-lsp:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #523 for a description of this error.
The author of the
pydocstyle_lint.pymodule made a mistake when he thought that pydocstyle ignores the--matchoption when we explicitly pass the path to a file for diagnosis. This behavior only occurs with respect to the--match-diroption. The link to the source code that proves this. As a result, users were unable to set thematchparameter in their configuration file inside a project.I fixed this error and did a little refactoring to get rid of the repetitive code.